-
Couldn't load subscription status.
- Fork 1.5k
[Firebase AI] Add parameters to SPT Chat sample #1793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new functionality to the Firebase AI Chat sample, enabling users to input their name and preferred language directly within the application's UI. These inputs are then dynamically passed to the generative AI model, allowing the system prompt to be customized based on user preferences. This change aims to demonstrate how to build more personalized and interactive AI experiences by leveraging user-provided context. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds name and language parameters to the Server Prompt Templates quickstart. The changes are well-implemented across the UI and ViewModel. The inclusion of template details as comments is a helpful addition for context. I have one suggestion to make the user input handling more robust.
Added
nameandlanguageto the Server Prompt Templates quickstart. If provided by the user, their name is added to the system prompt, else omitted. If specified, the language is added to the system prompt, else defaults to "English".